Repository navigation
Conversation
…uild `set_issuperset_impl()` is already locked but calls `set_issubset` which just wraps a lock to `set_issubset_impl`
picnixz
reviewed
Oct 15, 2026
Member
|
Are there othre places in the code where we have that useless double locking (not just limited to set, but limited to methods that do |
Contributor
Author
|
This came about from some sweeping research with claude but nothing else significant was found but I can try again focusing on the critical section tags. |
Member
|
If possible, please do so. That way we can just fix this in one go. If there are too many files, we can make focused PRs, but for mechanical changes like this, it's sometimes better to search beyond the scope of the file. |
Contributor
Author
|
#159559 for 5 found items which also seemed like low hanging fruit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set.issuperset#159486